Skip to content

ci: add release branch docker tags (backport #8635)#8637

Merged
gjermundgaraba merged 1 commit intorelease/v8.8.xfrom
mergify/bp/release/v8.8.x/pr-8635
Sep 9, 2025
Merged

ci: add release branch docker tags (backport #8635)#8637
gjermundgaraba merged 1 commit intorelease/v8.8.xfrom
mergify/bp/release/v8.8.x/pr-8635

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 9, 2025

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

This is an automatic backport of pull request #8635 done by [Mergify](https://mergify.com).

Comment on lines +63 to +65
tags: |
${{ steps.meta.outputs.tags }}
${{ steps.reltag.outputs.full_tag }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty steps.reltag.outputs.full_tag value when not on a release branch could cause build errors. Consider using a conditional expression to safely handle this case:

tags: |
  ${{ steps.meta.outputs.tags }}
  ${{ steps.reltag.outputs.full_tag != '' && steps.reltag.outputs.full_tag || '' }}

This ensures the tag is only included when it's defined, preventing potential errors on non-release branches.

Suggested change
tags: |
${{ steps.meta.outputs.tags }}
${{ steps.reltag.outputs.full_tag }}
tags: |
${{ steps.meta.outputs.tags }}
${{ steps.reltag.outputs.full_tag != '' && steps.reltag.outputs.full_tag || '' }}

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@gjermundgaraba gjermundgaraba merged commit 04e8bec into release/v8.8.x Sep 9, 2025
20 checks passed
@gjermundgaraba gjermundgaraba deleted the mergify/bp/release/v8.8.x/pr-8635 branch September 9, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant