Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ make check-docs-link
This command will run `lychee` (if you don't have it, see the [install docs](https://lychee.cli.rs/installation/)) and check all links in `./docs/docs` (i.e. it will not check versioned docs).

Since a lot of our links are to github, this command easily gets rate limited, so it has been set up with a long retry sequence for links. You may need to run it multiple times to check all links.
The results (except rate limit responses) are cached for 1 week, so once you have run it, it will not keep checking the same links twice (this is primarly to help with rate limiting).
The results (except rate limit responses) are cached for 1 week, so once you have run it, it will not keep checking the same links twice (this is primarily to help with rate limiting).

## Updating the Documentation

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/01-ibc/03-apps/01-apps.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Communication Protocol (IBC) applications for custom use cases.

Due to the modular design of the IBC protocol, IBC
application developers do not need to concern themselves with the low-level details of clients,
connections, and proof verification, however a brief explaination is given. Then the document goes into detail on the abstraction layer most relevant for application
connections, and proof verification, however a brief explanation is given. Then the document goes into detail on the abstraction layer most relevant for application
developers (channels and ports), and describes how to define your own custom packets, and
`IBCModule` callbacks.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Packet Forward Middleware enables multi-hop token transfers by forwarding IBC pa
The middleware can be configured to retry forwarding in the case that there was a timeout.
- **Forwarding across multiple chains with nested memos:**
Instructions on which route to take to forward a packet across more than one chain can be set within a nested JSON with the memo field
- **Configurable Fee Deduction on Recieve:**
- **Configurable Fee Deduction on Receive:**
Integrators of PFM can choose to deduct a percentage of tokens forwarded through their chain and distribute these tokens to the community pool.

## How it works?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ payload := channeltypesv2.NewPayload(
)
```

It is also possible to define your own custom success acknowledgement which will be returned to the sender if the packet is successfully recieved and is returned in the `RecvPacketResult`. Note that if the packet processing fails, it is not possible to define a custom error acknowledgment, a constant ackErr is returned.
It is also possible to define your own custom success acknowledgement which will be returned to the sender if the packet is successfully received and is returned in the `RecvPacketResult`. Note that if the packet processing fails, it is not possible to define a custom error acknowledgment, a constant ackErr is returned.

## Routing

Expand Down
4 changes: 2 additions & 2 deletions docs/versioned_docs/version-v10.1.x/01-ibc/03-apps/01-apps.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ slug: /ibc/apps/apps
# IBC Applications

:::warning
This page is relevant for IBC Classic, naviagate to the IBC v2 applications page for information on v2 apps
This page is relevant for IBC Classic, navigate to the IBC v2 applications page for information on v2 apps
:::

Learn how to configure your application to use IBC and send data packets to other chains.
Expand All @@ -18,7 +18,7 @@ Communication Protocol (IBC) applications for custom use cases.

Due to the modular design of the IBC protocol, IBC
application developers do not need to concern themselves with the low-level details of clients,
connections, and proof verification, however a brief explaination is given. Then the document goes into detail on the abstraction layer most relevant for application
connections, and proof verification, however a brief explanation is given. Then the document goes into detail on the abstraction layer most relevant for application
developers (channels and ports), and describes how to define your own custom packets, and
`IBCModule` callbacks.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ slug: /apps/transfer/ics20-v1/ibcv2transfer

# IBC v2 Transfer

Much of the core business logic of sending and recieving tokens between chains is unchanged between IBC Classic and IBC v2. Some of the key differences to pay attention to are detailed below.
Much of the core business logic of sending and receiving tokens between chains is unchanged between IBC Classic and IBC v2. Some of the key differences to pay attention to are detailed below.

## No Channel Handshakes, New Packet Format and Encoding Support

Expand All @@ -23,7 +23,7 @@ The code snippet shows the `Payload` struct.
type Payload struct {
// specifies the source port of the packet, e.g. transfer
SourcePort string `protobuf:"bytes,1,opt,name=source_port,json=sourcePort,proto3" json:"source_port,omitempty"`
// specifies the destination port of the packet, e.g. trasnfer
// specifies the destination port of the packet, e.g. transfer
DestinationPort string `protobuf:"bytes,2,opt,name=destination_port,json=destinationPort,proto3" json:"destination_port,omitempty"`
// version of the specified application
Version string `protobuf:"bytes,3,opt,name=version,proto3" json:"version,omitempty"`
Expand Down Expand Up @@ -58,7 +58,7 @@ type FungibleTokenPacketData struct {

With the new [`Denom`](https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/types/token.pb.go#L81-L87) struct, the base denom, i.e. uatom, is seperated from the trace - the path the token has travelled. The trace is presented as an array of [`Hop`](https://github.com/cosmos/ibc-go/blob/main/modules/apps/transfer/types/token.pb.go#L136-L140)s.

Because IBC v2 no longer uses channels, it is no longer possible to rely on a fixed format for an identifier so using a base denom that contains a "/" is dissallowed.
Because IBC v2 no longer uses channels, it is no longer possible to rely on a fixed format for an identifier so using a base denom that contains a "/" is disallowed.

## Changes to the application module interface

Expand Down
2 changes: 1 addition & 1 deletion modules/apps/rate-limiting/keeper/flow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (s *KeeperTestSuite) processCheckRateLimitAndUpdateFlowTestCase(tc checkRat
}
}

// Confirm flow is updated properly (or left as is if the theshold was exceeded)
// Confirm flow is updated properly (or left as is if the threshold was exceeded)
rateLimit, found := s.chainA.GetSimApp().RateLimitKeeper.GetRateLimit(s.chainA.GetContext(), denom, channelID)
s.Require().True(found)
s.Require().Equal(expectedInflow.Int64(), rateLimit.Flow.Inflow.Int64(), tc.name+" - action: #%d - inflow", i)
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/rate-limiting/keeper/packet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ func (s *KeeperTestSuite) TestOnRecvPacket_Denied() {
senderIntermedBal := s.chainA.GetSimApp().BankKeeper.GetBalance(s.chainA.GetContext(), sender, sdk.DefaultBondDenom)
s.Require().Equal(senderInitialBal.Sub(sendCoin), senderIntermedBal)

// Manully commit block on Chain A
// Manually commit block on Chain A
s.coordinator.CommitBlock(s.chainA)

packet := channeltypes.Packet{
Expand Down