Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8664 +/- ##
=======================================
Coverage 58.31% 58.31%
=======================================
Files 319 319
Lines 22821 22821
=======================================
Hits 13307 13307
Misses 8907 8907
Partials 607 607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
srdtrk
left a comment
srdtrk
left a comment
There was a problem hiding this comment.
Lgtm. Great documentation. I left some questions
|
|
||
| ### 0: Before release | ||
|
|
||
| 1. Before tagging a new release, make sure to run the [compatibility e2e test suite](https://github.com/cosmos/ibc-go/actions/workflows/e2e-compatibility.yaml) for the corresponding release line. |
There was a problem hiding this comment.
Do we also run some upgrade tests?
There was a problem hiding this comment.
Hmm, good question. It was never part of the release flow. Maybe it should be. I don't have a super good overview over those tests, and if there would need to be any changes to support a specific branch or whatever 🤔
There was a problem hiding this comment.
Hmm, I checked a bit more, and I don't know what the best procedure is, but what I did for v10.4.x leading up to the release was building a tag and updating ci-e2e-config.yaml:
- planName: "v10"
tag: "branch-release-v10.4.x"
There was a problem hiding this comment.
Should I put this into the docs?
There was a problem hiding this comment.
Yes. Maybe mark it optional if you don't always do this?
| - github.com/cosmos/ibc-go/v10 v10.3.0 | ||
| + github.com/cosmos/ibc-go/v10 v10.4.0 | ||
| ``` | ||
| 3. Create a PR to the release branch, and after CI finishes, merge it. |
There was a problem hiding this comment.
Do the e2e compatibility tests cover submodules?
There was a problem hiding this comment.
Doesn't look that way
There was a problem hiding this comment.
You can see what it runs in e2e-compatibility.yaml
3 participants
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.