Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8734 +/- ##
==========================================
- Coverage 58.62% 58.60% -0.03%
==========================================
Files 329 329
Lines 18484 18498 +14
==========================================
+ Hits 10837 10841 +4
- Misses 6998 7003 +5
- Partials 649 654 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aljo242
approved these changes
Dec 17, 2025
Contributor
aljo242
left a comment
aljo242
left a comment
There was a problem hiding this comment.
lgtm - we just need to document this change
mergify bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
* imp: add extra validation * chore: lint * imp: error msg * test: fix tests * docs: document the validation change --------- Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io> (cherry picked from commit 7574333) # Conflicts: # docs/docs/02-apps/02-interchain-accounts/07-tx-encoding.md # modules/apps/27-interchain-accounts/host/keeper/relay_test.go
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
* imp: add extra validation * chore: lint * imp: error msg * test: fix tests * docs: document the validation change --------- Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io> (cherry picked from commit 7574333)
7 tasks
srdtrk
added a commit
that referenced
this pull request
Dec 18, 2025
* imp: add extra validation to ica msgs (#8734) * imp: add extra validation * chore: lint * imp: error msg * test: fix tests * docs: document the validation change --------- Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io> (cherry picked from commit 7574333) * fix: test compilation * fix: remove non-existant field * docs: update changelog --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io> Co-authored-by: srdtrk <srdtrk@hotmail.com>
srdtrk
added a commit
that referenced
this pull request
Dec 18, 2025
* imp: add extra validation to ica msgs (#8734) * imp: add extra validation * chore: lint * imp: error msg * test: fix tests * docs: document the validation change --------- Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io> (cherry picked from commit 7574333) # Conflicts: # docs/docs/02-apps/02-interchain-accounts/07-tx-encoding.md # modules/apps/27-interchain-accounts/host/keeper/relay_test.go * fix: conflicts * fix: use ErrUnknownDataType instead of ibcerrors.ErrInvalidType * test: fix * lint: gci * test: fix * chore: remove unused diff * docs: update changelog --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.