bug: Fix iterator string conflict in rate limiting#8767
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8767 +/- ##
=======================================
Coverage 66.56% 66.57%
=======================================
Files 326 326
Lines 17101 17103 +2
=======================================
+ Hits 11384 11386 +2
Misses 5021 5021
Partials 696 696
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
srdtrk
left a comment
There was a problem hiding this comment.
Lgtm. I understand why this fixes the issue. It seems we would have key collision problems if channel numbers get way too big right?
So if len([]byte(channelId)) > 16?
Yeah I think this is already the case. |
Description
Fixes a conflict when using string prefix iterator in rate limitting.
Updated unit test fails w/o patch and succeeds with it.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.