Skip to content

bug: Fix iterator string conflict in rate limiting#8767

Merged
Eric-Warehime merged 3 commits intomainfrom
eric/iter-fix
Feb 6, 2026
Merged

bug: Fix iterator string conflict in rate limiting#8767
Eric-Warehime merged 3 commits intomainfrom
eric/iter-fix

Conversation

@Eric-Warehime
Copy link
Contributor

Description

Fixes a conflict when using string prefix iterator in rate limitting.

Updated unit test fails w/o patch and succeeds with it.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.57%. Comparing base (491c7a3) to head (58961fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8767   +/-   ##
=======================================
  Coverage   66.56%   66.57%           
=======================================
  Files         326      326           
  Lines       17101    17103    +2     
=======================================
+ Hits        11384    11386    +2     
  Misses       5021     5021           
  Partials      696      696           
Flag Coverage Δ
08-wasm 64.81% <ø> (ø)
ibc-go 66.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I understand why this fixes the issue. It seems we would have key collision problems if channel numbers get way too big right?

So if len([]byte(channelId)) > 16?

@Eric-Warehime
Copy link
Contributor Author

Lgtm. I understand why this fixes the issue. It seems we would have key collision problems if channel numbers get way too big right?

So if len([]byte(channelId)) > 16?

Yeah I think this is already the case.

@Eric-Warehime Eric-Warehime enabled auto-merge (squash) February 6, 2026 16:48
@Eric-Warehime Eric-Warehime merged commit 9ffc748 into main Feb 6, 2026
55 checks passed
@Eric-Warehime Eric-Warehime deleted the eric/iter-fix branch February 6, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants