Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8771 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 326 326
Lines 17103 17103
=======================================
Hits 11386 11386
Misses 5021 5021
Partials 696 696
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| var invalidAddress = "invalid" | ||
|
|
There was a problem hiding this comment.
We can use ibctesting.InvalidID instead
| "failure: invalid sender address", | ||
| func() { | ||
| msg.Sender = "invalid" | ||
| msg.Sender = invalidAddress |
There was a problem hiding this comment.
ditto: We can use ibctesting.InvalidID instead
| invalidClientID = "invalid" | ||
| invalidPort = "invalid-port" |
There was a problem hiding this comment.
ditto: We can use ibctesting.InvalidID instead
There was a problem hiding this comment.
These are critical functions that were audited. Would be good to not modify if not needed.
I only see some semantic changes that doesn't provide any safetly/utility.
| if reply.Result.Ok != nil { | ||
| msgLen += len(reply.Result.Ok.Data) | ||
| var attrs []wasmvmtypes.EventAttribute | ||
| attrs := make([]wasmvmtypes.EventAttribute, 0, msgLen) |
There was a problem hiding this comment.
I don't even think this is correct. Neither the length nor capacity should be msgLen. You can see in the for loop below, that to determine the length, you probably need to a for loop first. Here, having variable length feels easier to read and reason about
|
closing this |
2 participants
No description provided.