Skip to content

feat(attestations): add domain separation to signature verification#8799

Merged
srdtrk merged 6 commits intomainfrom
mariuszzak/attestation-fix
Feb 23, 2026
Merged

feat(attestations): add domain separation to signature verification#8799
srdtrk merged 6 commits intomainfrom
mariuszzak/attestation-fix

Conversation

@mariuszzak
Copy link
Collaborator

@mariuszzak mariuszzak commented Feb 19, 2026

Description

Adds domain separation to attestation signature verification to prevent cross-protocol signature replay. The signing input changes from sha256(data) to sha256(type_tag || sha256(data)) where State=0x01 and Packet=0x02, ensuring signatures for state updates and packet proofs are not interchangeable.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@mariuszzak mariuszzak self-assigned this Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.59%. Comparing base (eb52d21) to head (0ded97d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8799      +/-   ##
==========================================
+ Coverage   66.56%   66.59%   +0.03%     
==========================================
  Files         326      326              
  Lines       17106    17112       +6     
==========================================
+ Hits        11386    11396      +10     
+ Misses       5024     5022       -2     
+ Partials      696      694       -2     
Flag Coverage Δ
08-wasm 64.81% <ø> (ø)
ibc-go 66.65% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mariuszzak mariuszzak marked this pull request as ready for review February 19, 2026 16:54
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srdtrk srdtrk merged commit 73cea87 into main Feb 23, 2026
54 checks passed
@srdtrk srdtrk deleted the mariuszzak/attestation-fix branch February 23, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants