fix: use getChannel instead of getConnection for channel queries#1244
Open
Lil-Duckling-22 wants to merge 1 commit intocosmos:mainfrom
Open
fix: use getChannel instead of getConnection for channel queries#1244Lil-Duckling-22 wants to merge 1 commit intocosmos:mainfrom
Lil-Duckling-22 wants to merge 1 commit intocosmos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The channel handshake logic in pendingDatagrams incorrectly uses getConnection() with a non-existent counterpartyIdentifier field when querying channels. This breaks the example code since ChannelEnd doesn't have counterpartyIdentifier—it uses counterpartyPortIdentifier and counterpartyChannelIdentifier.
Solution
Replace counterparty.getConnection(localEnd.counterpartyIdentifier) with counterparty.getChannel(localEnd.counterpartyPortIdentifier, localEnd.counterpartyChannelIdentifier) to correctly query the counterparty channel end using the proper method and fields from the ChannelEnd structure.