-
Notifications
You must be signed in to change notification settings - Fork 59
chore(solana): handle action items vol 4 #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
+ Coverage 72.88% 73.03% +0.14%
==========================================
Files 109 110 +1
Lines 15260 15359 +99
==========================================
+ Hits 11123 11217 +94
- Misses 4137 4142 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3f8b62f to
3a500ef
Compare
cernicc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
programs/solana/programs/access-manager/src/instructions/upgrade_program.rs
Show resolved
Hide resolved
srdtrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm in general. Left some improvement suggestions
srdtrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Just left a question which you may wanna address before merging
Description
This PR addresses the issues we discovered during the code walk-through session.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.