Skip to content

Conversation

@mariuszzak
Copy link
Collaborator

@mariuszzak mariuszzak commented Dec 8, 2025

Description

This PR addresses the issues we discovered during the code walk-through session.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@mariuszzak mariuszzak self-assigned this Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 62.69531% with 191 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.03%. Comparing base (9047769) to head (dbee3da).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ms/solana/packages/solana-ibc-types/src/ibc_app.rs 0.00% 97 Missing ⚠️
...ograms/ics26-router/src/instructions/ack_packet.rs 0.00% 18 Missing ⚠️
...grams/ics26-router/src/instructions/recv_packet.rs 0.00% 17 Missing ⚠️
...ms/ics26-router/src/instructions/timeout_packet.rs 0.00% 17 Missing ⚠️
...access-manager/src/instructions/upgrade_program.rs 50.00% 11 Missing ⚠️
...rograms/solana/programs/ics26-router/src/events.rs 0.00% 8 Missing ⚠️
...rams/solana/packages/solana-ibc-types/src/ics27.rs 91.80% 5 Missing ⚠️
...grams/ics27-gmp/src/instructions/on_recv_packet.rs 0.00% 4 Missing ⚠️
...ograms/solana/packages/solana-ibc-types/src/cpi.rs 0.00% 2 Missing ⚠️
...cs26-router/src/instructions/set_access_manager.rs 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   72.88%   73.03%   +0.14%     
==========================================
  Files         109      110       +1     
  Lines       15260    15359      +99     
==========================================
+ Hits        11123    11217      +94     
- Misses       4137     4142       +5     
Flag Coverage Δ
solana 70.99% <62.69%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mariuszzak mariuszzak marked this pull request as ready for review December 9, 2025 07:35
@mariuszzak mariuszzak requested a review from srdtrk as a code owner December 9, 2025 07:35
Base automatically changed from feat/solana to main December 19, 2025 18:19
@mariuszzak mariuszzak force-pushed the mariuszzak/action_items_part_4 branch from 3f8b62f to 3a500ef Compare December 22, 2025 10:47
Copy link
Collaborator

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm in general. Left some improvement suggestions

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Just left a question which you may wanna address before merging

@srdtrk srdtrk merged commit cf2878a into main Jan 21, 2026
161 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants