feat(solana): gmp result pda #870

vaporif · 2025-12-19T18:24:57Z

Description

closes: #849

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
Wrote unit and integration tests.
Added relevant natspec and godoc comments.
Provide a conventional commit message to follow the repository standards.
Re-reviewed Files changed in the GitHub PR explorer.
Review SonarCloud Report in the comment section below once CI passes.

codecov · 2025-12-19T19:06:30Z

Codecov Report

❌ Patch coverage is 91.89189% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.73%. Comparing base (c326e08) to head (9f1fd5d).

Files with missing lines	Patch %	Lines
...ograms/ics27-gmp/src/instructions/on_ack_packet.rs	92.24%	20 Missing ⚠️
...ms/ics27-gmp/src/instructions/on_timeout_packet.rs	92.15%	20 Missing ⚠️
programs/solana/programs/ics27-gmp/src/lib.rs	0.00%	4 Missing ⚠️
...rams/solana/packages/solana-ibc-types/src/utils.rs	50.00%	3 Missing ⚠️
programs/solana/programs/ics27-gmp/src/events.rs	0.00%	2 Missing ⚠️
...rams/solana/packages/solana-ibc-types/src/ics27.rs	90.00%	1 Missing ⚠️
programs/solana/programs/ics27-gmp/src/state.rs	98.93%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   73.03%   73.73%   +0.70%     
==========================================
  Files         110      110              
  Lines       15359    15930     +571     
==========================================
+ Hits        11217    11746     +529     
- Misses       4142     4184      +42

Flag	Coverage Δ
solana	`71.82% <91.89%> (+0.83%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

srdtrk

The approach is good imo. I left some improvements and suggestions, would be good to get CI passing as well, including coverage)

packages/relayer/modules/cosmos-to-solana/src/gmp.rs

programs/solana/packages/solana-ibc-types/src/ics27.rs

programs/solana/programs/ics27-gmp/src/events.rs

programs/solana/programs/ics27-gmp/src/instructions/on_timeout_packet.rs

programs/solana/programs/ics27-gmp/src/state.rs

programs/solana/packages/solana-ibc-types/src/ics27.rs

e2e/interchaintestv8/solana_gmp_test.go

Co-authored-by: srdtrk <[email protected]>

# Conflicts: # e2e/interchaintestv8/solana_gmp_test.go

srdtrk

Just address it, and the rest be handled in IFT PR

e2e/interchaintestv8/solana_gmp_test.go

packages/relayer/modules/cosmos-to-solana/src/tx_builder/chunking.rs

packages/relayer/modules/cosmos-to-solana/src/tx_builder/packets.rs

programs/solana/programs/ics27-gmp/src/instructions/on_ack_packet.rs

programs/solana/programs/ics27-gmp/src/instructions/on_timeout_packet.rs

programs/solana/programs/ics27-gmp/src/state.rs

codecov · 2026-01-22T14:05:47Z

Codecov Report

❌ Patch coverage is 92.37805% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.72%. Comparing base (5c4f371) to head (ab51df5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ograms/ics27-gmp/src/instructions/on_ack_packet.rs	92.33%	20 Missing ⚠️
...ms/ics27-gmp/src/instructions/on_timeout_packet.rs	92.15%	20 Missing ⚠️
programs/solana/programs/ics27-gmp/src/lib.rs	0.00%	4 Missing ⚠️
...rams/solana/packages/solana-ibc-types/src/utils.rs	0.00%	2 Missing ⚠️
programs/solana/programs/ics27-gmp/src/events.rs	0.00%	2 Missing ⚠️
...rams/solana/packages/solana-ibc-types/src/ics27.rs	90.00%	1 Missing ⚠️
programs/solana/programs/ics27-gmp/src/state.rs	98.98%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   73.03%   73.72%   +0.69%     
==========================================
  Files         110      110              
  Lines       15359    15923     +564     
==========================================
+ Hits        11217    11739     +522     
- Misses       4142     4184      +42

Flag	Coverage Δ
solana	`71.81% <92.37%> (+0.81%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

programs/solana/packages/solana-ibc-types/src/utils.rs

programs/solana/programs/ics27-gmp/src/events.rs

srdtrk · 2026-01-22T16:14:53Z

programs/solana/programs/ics27-gmp/src/events.rs

 }
+
+#[event]
+pub struct GMPCallAcknowledged {


Not resolved

srdtrk · 2026-01-22T16:18:23Z

packages/relayer/modules/cosmos-to-solana/src/tx_builder/chunking.rs

+                    .map(|pda| pda.to_bytes().to_vec())
+                })
+                .unwrap_or_default()),
+            [] => Ok(vec![]),


Is this because the function has to handle non-gmp payloads? Otherwise why is this not an error

yes, it is handling non-gmp payload since it's used in build_ack_packet_chunked

…ty-ibc-eureka into vaporif/gmp-result

srdtrk

lgtm. Can merge when CI passes

vaporif requested a review from srdtrk as a code owner December 19, 2025 18:24

vaporif added 9 commits December 19, 2025 18:55

gmp result implementation

9b2b5e5

cleanup

89673e6

simplify

3f1f76d

update

39c025b

fmt

f960cf8

clippy

b879d38

lint

428c6a7

comment

3e252d2

add docs

db94555

vaporif force-pushed the vaporif/gmp-result branch from aba3596 to db94555 Compare December 19, 2025 18:56

vaporif added 3 commits January 12, 2026 13:04

Merge branch 'main' into vaporif/gmp-result

74a9a92

Merge branch 'main' into vaporif/gmp-result

207ef52

Merge branch 'main' into vaporif/gmp-result

025411b

srdtrk requested changes Jan 15, 2026

View reviewed changes

vaporif and others added 14 commits January 15, 2026 13:45

Update programs/solana/packages/solana-ibc-types/src/ics27.rs

0428e14

Co-authored-by: srdtrk <[email protected]>

Update programs/solana/packages/solana-ibc-types/src/ics27.rs

204229d

Co-authored-by: srdtrk <[email protected]>

Update programs/solana/programs/ics27-gmp/src/events.rs

acd0bb9

Co-authored-by: srdtrk <[email protected]>

rename find gmp pda

d5b0d10

invalid sequence check

28eb544

naming

4bffebb

normalize names

cc323b7

simplify

b72c1bf

Merge remote-tracking branch 'origin/main' into vaporif/gmp-result

3fc29e9

# Conflicts: # e2e/interchaintestv8/solana_gmp_test.go

validate fields

2626b58

post merge fix

e6341d6

re-regen

e196866

post merge fix

85e1ad3

namespaced

c9c9973

vaporif added 3 commits January 19, 2026 19:43

edge cases

c5e958a

more tests

27add38

lint

83fbe56

srdtrk requested changes Jan 21, 2026

View reviewed changes

vaporif added 11 commits January 21, 2026 19:54

ack enum refactor

f9b6abe

use ibc commitment

9d26942

change to pubkey

6ce968f

update

1fe8f2b

Merge branch 'main' into vaporif/gmp-result

affba30

chunking

dbeb0f5

mergefix

2711747

upd

080f0dc

commitment check

9f1fd5d

errs

5f91a38

cleanup

b08791d

vaporif requested a review from srdtrk January 22, 2026 14:53

vaporif added 3 commits January 22, 2026 14:55

copy

948f2a4

chunking refact

360e776

Merge branch 'main' into vaporif/gmp-result

c45563d

srdtrk reviewed Jan 22, 2026

View reviewed changes

vaporif added 6 commits January 22, 2026 16:43

reduce duplication/use solana hashing

997ff24

Merge branch 'vaporif/gmp-result' of https://github.com/cosmos/solidi…

c643a07

…ty-ibc-eureka into vaporif/gmp-result

remova sha2

219df24

event renames

1c489a0

preallocation

654cce0

preallocs

ab51df5

srdtrk approved these changes Jan 22, 2026

View reviewed changes

vaporif merged commit 65a2205 into main Jan 22, 2026
211 of 212 checks passed

vaporif deleted the vaporif/gmp-result branch January 22, 2026 17:37

feat(solana): gmp result pda #870

feat(solana): gmp result pda #870

Uh oh!

Conversation

vaporif commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

codecov bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

srdtrk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srdtrk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

srdtrk Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

srdtrk Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

vaporif Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srdtrk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vaporif commented Dec 19, 2025 •

edited

Loading

codecov bot commented Dec 19, 2025 •

edited

Loading

codecov bot commented Jan 22, 2026 •

edited

Loading

vaporif Jan 22, 2026 •

edited

Loading