fix(solana): sig verification #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 26 26
Lines 1084 1084
=======================================
Hits 1083 1083
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cernicc
reviewed
Dec 30, 2025
.github/workflows/foundry.yml
Outdated
|
|
||
| - uses: srdtrk/natlint@main | ||
| -- TODO: update original repo | ||
| - uses: vaporif/natlint@drop-forge-fmt |
Collaborator
There was a problem hiding this comment.
I suggest we solve this todo before merging.
|
|
||
| // Compile-time verification that discriminator length matches the shared constant | ||
| const _: () = assert!( | ||
| SignatureVerification::DISCRIMINATOR.len() == solana_ibc_constants::ANCHOR_DISCRIMINATOR_LEN |
Collaborator
There was a problem hiding this comment.
I like the compile time check for the discriminator length. One question. When can the lengths be different?
Collaborator
Author
There was a problem hiding this comment.
potentially anchor allows setting custom discriminators (non 8 bytes).
it's not widely used feature but still better to have this as safeguard
srdtrk
approved these changes
Jan 8, 2026
.github/workflows/foundry.yml
Outdated
|
|
||
| - uses: srdtrk/natlint@main | ||
| -- TODO: update original repo | ||
| - uses: vaporif/natlint@drop-forge-fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.