Replace boost and fmt functionality with C++20 features and update CEF#410
Open
Replace boost and fmt functionality with C++20 features and update CEF#410
Conversation
# Conflicts: # CMakeLists.txt # plugins/csp-lod-bodies/src/TreeManager.cpp
…olled on a browser level anymore.
Schneegans
reviewed
Apr 30, 2025
Co-authored-by: Simon Schneegans <simon.schneegans@dlr.de>
Schneegans
requested changes
May 7, 2025
Member
Schneegans
left a comment
There was a problem hiding this comment.
Code-wise it looks good. I'll do some in-depth testing next.
Co-authored-by: Simon Schneegans <simon.schneegans@dlr.de>
Member
Author
Thanks, this is not an urgent PR (also why this is in draft mode), since we currently have to support Ubuntu 22.04 which doesn't have gcc-13. Maybe in the next months we can drop Ubuntu 22.04 support. But you can review it nonetheless if you have the time. |
Schneegans
approved these changes
May 8, 2025
Member
Schneegans
left a comment
There was a problem hiding this comment.
I think everything looks good! Thanks for this work!
# Conflicts: # .github/workflows/deploy.yml # plugins/csp-lod-bodies/src/TileSourceWebMapService.cpp # src/cs-core/Settings.cpp
…ce-boost # Conflicts: # make_externals.bat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces:
This PR also updates CEF to version 135, to fix some C++ deprecation issues.
This reduces our dependencies and makes the setup of CosmoScout VR easier.
This change requires gcc-13 or Visual Studio 2019. gcc-13 is the default compiler on Ubuntu 24.04. There are some more possible improvements in date time parsing that would require gcc-14, but since this is not the default compiler on any LTS version of Ubuntu I skipped these improvements.