Skip to content

Fix error in sharad plugin that rendered wrong when HDR was disabled#426

Merged
JonasGilg merged 1 commit intomainfrom
feature/fix-sharad-rendering
Mar 10, 2026
Merged

Fix error in sharad plugin that rendered wrong when HDR was disabled#426
JonasGilg merged 1 commit intomainfrom
feature/fix-sharad-rendering

Conversation

@JonasGilg
Copy link
Copy Markdown
Member

@JonasGilg JonasGilg commented Mar 10, 2026

Same fix as in #421.

@JonasGilg JonasGilg requested a review from Slinyu March 10, 2026 14:06
@JonasGilg JonasGilg self-assigned this Mar 10, 2026
@JonasGilg JonasGilg added the bug Something isn't working label Mar 10, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22906511745

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 1.189%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-sharad/src/Sharad.cpp 0 1 0.0%
Totals Coverage Status
Change from base Build 22671524816: 0.0%
Covered Lines: 201
Relevant Lines: 16911

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@Slinyu Slinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Render works both in SDR and HDR.

@JonasGilg JonasGilg merged commit d26a33b into main Mar 10, 2026
12 checks passed
@JonasGilg JonasGilg deleted the feature/fix-sharad-rendering branch March 10, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants