-
Notifications
You must be signed in to change notification settings - Fork 156
Update RN Themis to 0.15.5: Android support 16 KB page sizes #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/0.15.0
Are you sure you want to change the base?
Conversation
| "react": "19.2.0", | ||
| "react-native": "0.83.0", | ||
| "react-native-safe-area-context": "^5.5.2", | ||
| "react-native-themis": "file:../../../AndroidStudioProjects/themis/src/wrappers/themis/react-native-themis/react-native-themis-0.15.5.tgz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be updated when library published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR you may install actual version from local file, but replace the string in package.json :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks 🙂
The local install was used only for testing during development.
| styles.sectionTitle, | ||
| { | ||
| color: isDarkMode ? Colors.white : Colors.black, | ||
| color: isDarkMode ? '#F5FCFF' : '#94cce3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may create your own constants instead of raw values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, that makes sense.
Replaced the raw values with named constants to improve readability and maintainability.
radetsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Thank you.
|
|
||
| gem 'cocoapods', '~> 1.12' | ||
| gem 'activesupport', '~> 7.0', '<= 7.0.8' | ||
| # Exclude problematic versions of cocoapods and activesupport that causes build failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
|
neat, looking forward |
0dee5f8 to
fd4ca1a
Compare
Main Changes
Updated RN Themis library to version 0.15.5 — bumping the bundled React-Native Themis binary to the latest release.
Android support 16 KB page sizes
Example app refresh - updated React-Native example project to align with the updated RN Themis version.
Code improvements and cleanup in example files.
Checklist