Fix StackOverflowException on StringUtil.Create #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces stricter validation for mailbox creation in the SMTP parser to prevent malformed or excessively large mailbox names from being accepted. The main changes are focused on enhancing error handling and input validation when constructing mailbox objects.
Mailbox creation validation and error handling:
TryMakeMailboxinSmtpParser.csto throw anSmtpResponseExceptionwithMailboxNameNotAllowedif mailbox creation fails due to invalid input, instead of silently returning null.CreateMailboxhelper to check for null values after converting the local part and domain/address, ensuring that mailbox objects are only created with valid data.Input size validation:
StringUtil.Createto return null if the input sequence length exceedsushort.MaxValue, preventing creation of mailbox names that are too large.