-
-
Notifications
You must be signed in to change notification settings - Fork 35
ci: remove rust-lang/rust#145288 workaround #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Rust CI workflow to unpin the nightly compiler version. Previously, the nightly version was pinned to nightly-2025-08-11 due to a compiler bug (rust-lang/rust#145288). The change removes this pinning and reverts to using the latest nightly version in the build matrix.
- Removed the pinned
nightly-2025-08-11version and replaced it withnightly - Removed comments explaining the temporary pinning due to the compiler bug
Comments suppressed due to low confidence (5)
.github/workflows/rust.yml:144
- The nightly version is still pinned to
nightly-2025-08-11in the external-deps job. This should be updated tonightlyto be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
toolchain: nightly-2025-08-11
.github/workflows/rust.yml:190
- The nightly version is still pinned to
nightly-2025-08-11in the coverage job. This should be updated tonightlyto be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
toolchain: nightly-2025-08-11
.github/workflows/rust.yml:243
- The nightly version is still pinned to
nightly-2025-08-11in the formatting job. This should be updated tonightlyto be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
toolchain: nightly-2025-08-11
.github/workflows/rust.yml:294
- The nightly version is still pinned to
nightly-2025-08-11in the unused-dependencies job. This should be updated tonightlyto be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
toolchain: nightly-2025-08-11
.github/workflows/rust.yml:363
- The nightly version is still pinned to
nightly-2025-08-11in the miri job. This should be updated tonightlyto be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
toolchain: nightly-2025-08-11
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| Branch | rust145288-workaround-remove |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,294.70 µs(+3.13%)Baseline: 6,103.63 µs | 6,471.26 µs (97.27%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,027.50 µs(-0.32%)Baseline: 1,030.83 µs | 1,062.36 µs (96.72%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 959.40 µs(+0.13%)Baseline: 958.13 µs | 1,010.09 µs (94.98%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 920.52 µs(+0.56%)Baseline: 915.36 µs | 951.00 µs (96.80%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17,482.00 µs(-1.06%)Baseline: 17,668.44 µs | 21,029.23 µs (83.13%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
No description provided.