Skip to content

Conversation

@m4tx
Copy link
Member

@m4tx m4tx commented Nov 5, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 5, 2025 19:06
@github-actions github-actions bot added the A-ci Area: CI (Continuous Integration) label Nov 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rust CI workflow to unpin the nightly compiler version. Previously, the nightly version was pinned to nightly-2025-08-11 due to a compiler bug (rust-lang/rust#145288). The change removes this pinning and reverts to using the latest nightly version in the build matrix.

  • Removed the pinned nightly-2025-08-11 version and replaced it with nightly
  • Removed comments explaining the temporary pinning due to the compiler bug
Comments suppressed due to low confidence (5)

.github/workflows/rust.yml:144

  • The nightly version is still pinned to nightly-2025-08-11 in the external-deps job. This should be updated to nightly to be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
          toolchain: nightly-2025-08-11

.github/workflows/rust.yml:190

  • The nightly version is still pinned to nightly-2025-08-11 in the coverage job. This should be updated to nightly to be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
          toolchain: nightly-2025-08-11

.github/workflows/rust.yml:243

  • The nightly version is still pinned to nightly-2025-08-11 in the formatting job. This should be updated to nightly to be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
          toolchain: nightly-2025-08-11

.github/workflows/rust.yml:294

  • The nightly version is still pinned to nightly-2025-08-11 in the unused-dependencies job. This should be updated to nightly to be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
          toolchain: nightly-2025-08-11

.github/workflows/rust.yml:363

  • The nightly version is still pinned to nightly-2025-08-11 in the miri job. This should be updated to nightly to be consistent with the change in the build matrix, unless there's a specific reason to keep it pinned here.
          toolchain: nightly-2025-08-11

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

🐰 Bencher Report

Branchrust145288-workaround-remove
Testbedgithub-ubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
empty_router/empty_router📈 view plot
🚷 view threshold
6,294.70 µs
(+3.13%)Baseline: 6,103.63 µs
6,471.26 µs
(97.27%)
json_api/json_api📈 view plot
🚷 view threshold
1,027.50 µs
(-0.32%)Baseline: 1,030.83 µs
1,062.36 µs
(96.72%)
nested_routers/nested_routers📈 view plot
🚷 view threshold
959.40 µs
(+0.13%)Baseline: 958.13 µs
1,010.09 µs
(94.98%)
single_root_route/single_root_route📈 view plot
🚷 view threshold
920.52 µs
(+0.56%)Baseline: 915.36 µs
951.00 µs
(96.80%)
single_root_route_burst/single_root_route_burst📈 view plot
🚷 view threshold
17,482.00 µs
(-1.06%)Baseline: 17,668.44 µs
21,029.23 µs
(83.13%)
🐰 View full continuous benchmarking report in Bencher

Copilot AI review requested due to automatic review settings November 5, 2025 20:01
@github-actions github-actions bot added C-lib Crate: cot (main library crate) C-macros Crate: cot-macros labels Nov 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
rust 90.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m4tx m4tx merged commit 5816fb9 into master Nov 5, 2025
38 checks passed
@m4tx m4tx deleted the rust145288-workaround-remove branch November 5, 2025 21:00
@cotbot cotbot bot mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI (Continuous Integration) C-lib Crate: cot (main library crate) C-macros Crate: cot-macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants