Skip to content

Conversation

@m4tx
Copy link
Member

@m4tx m4tx commented Nov 20, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in the dbtest procedural macro by replacing unwrap() calls with expect() calls that include descriptive error messages. This makes debugging easier when database test setup or cleanup fails.

  • Replaces 6 unwrap() calls with expect() calls containing descriptive error messages
  • Applies changes uniformly across all three database types (SQLite, PostgreSQL, and MySQL)
  • Error messages follow a consistent pattern describing the operation and database type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

🐰 Bencher Report

Branchdbtest-expect
Testbedgithub-ubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
empty_router/empty_router📈 view plot
🚷 view threshold
6,201.60 µs
(+1.32%)Baseline: 6,120.86 µs
6,467.22 µs
(95.89%)
json_api/json_api📈 view plot
🚷 view threshold
1,054.60 µs
(+1.84%)Baseline: 1,035.54 µs
1,074.44 µs
(98.15%)
nested_routers/nested_routers📈 view plot
🚷 view threshold
970.62 µs
(+1.08%)Baseline: 960.23 µs
1,010.10 µs
(96.09%)
single_root_route/single_root_route📈 view plot
🚷 view threshold
920.87 µs
(+0.52%)Baseline: 916.13 µs
949.41 µs
(96.99%)
single_root_route_burst/single_root_route_burst📈 view plot
🚷 view threshold
17,574.00 µs
(-0.88%)Baseline: 17,729.84 µs
21,122.40 µs
(83.20%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
rust 90.66% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot-macros/src/dbtest.rs 71.42% <ø> (ø)

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m4tx m4tx merged commit 3293af6 into master Nov 20, 2025
43 checks passed
@m4tx m4tx deleted the dbtest-expect branch November 20, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-macros Crate: cot-macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants