chore: use MSRV-aware resolver, ignore nightly failures

[m4tx]

No description provided.

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Bencher Report

Branch	bump-lockfile
Testbed	github-ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
empty_router/empty_router	📈 view plot 🚷 view threshold	6,179.10 µs (+1.87%) Baseline: 6,065.71 µs	6,750.32 µs (91.54%)
json_api/json_api	📈 view plot 🚷 view threshold	1,048.90 µs (+2.15%) Baseline: 1,026.82 µs	1,127.00 µs (93.07%)
nested_routers/nested_routers	📈 view plot 🚷 view threshold	954.09 µs (+0.22%) Baseline: 952.00 µs	1,046.60 µs (91.16%)
single_root_route/single_root_route	📈 view plot 🚷 view threshold	922.70 µs (+1.45%) Baseline: 909.51 µs	990.61 µs (93.15%)
single_root_route_burst/single_root_route_burst	📈 view plot 🚷 view threshold	16,926.00 µs (-4.08%) Baseline: 17,646.15 µs	21,010.44 µs (80.56%)

🐰 View full continuous benchmarking report in Bencher

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment states "1.85 is the MSRV" but the code tests version "1.86" which matches the rust-version = "1.86" in Cargo.toml. The comment should be updated to say "1.86 is the MSRV" to avoid confusion.

Suggested change

	rust: [stable, "1.86"] # 1.85 is the MSRV
	rust: [stable, "1.86"] # 1.86 is the MSRV

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The nightly build configuration is incomplete. Adding nightly only to the include section without an os value means it will only run on one OS (the default), but this is not explicitly defined. To run nightly builds on all platforms, you should either:

1. Add it back to the matrix and handle errors differently, or
2. Specify the os in the include section explicitly

Suggested fix:

include:
  - rust: nightly
    os: ubuntu-latest
    continue-on-error: true
  - rust: nightly
    os: macos-latest
    continue-on-error: true
  - rust: nightly
    os: windows-latest
    continue-on-error: true

Suggested change

	- rust: nightly
	continue-on-error: true
	- rust: nightly
	os: ubuntu-latest
	continue-on-error: true
	- rust: nightly
	os: macos-latest
	continue-on-error: true
	- rust: nightly
	os: windows-latest
	continue-on-error: true

[Copilot]

The continue-on-error property will be undefined for most matrix combinations. The expression ${{ matrix.continue-on-error }} will evaluate to an empty string (falsy) for stable and 1.86 builds, which is the desired behavior. However, for the nightly build(s), this will work correctly.

A more explicit approach would be:

continue-on-error: ${{ matrix.continue-on-error || false }}

This makes the default behavior explicit.

Suggested change

	continue-on-error: ${{ matrix.continue-on-error }}
	continue-on-error: ${{ matrix.continue-on-error || false }}

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.