chore: allow clippy::needless_continue
#428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR allows the clippy::needless_continue lint while referencing an upstream Clippy issue for potential future resolution. The change also updates the pedantic lint configuration to use explicit level and priority settings for consistency.
- Standardized the
pedanticlint configuration format to match other lint configurations - Allowed
clippy::needless_continuewith a TODO comment linking to the relevant Clippy issue (#16175)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bencher Report| Branch | clippy-needless-continue |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,202.70 µs(+2.69%)Baseline: 6,040.48 µs | 6,801.18 µs (91.20%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,045.20 µs(+2.30%)Baseline: 1,021.66 µs | 1,133.22 µs (92.23%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 972.64 µs(+2.73%)Baseline: 946.84 µs | 1,048.26 µs (92.79%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 927.56 µs(+2.39%)Baseline: 905.87 µs | 999.75 µs (92.78%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 20,611.00 µs(+15.29%)Baseline: 17,877.74 µs | 21,454.66 µs (96.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there was a clippy regression (rust-lang/rust-clippy#16175) that causes the CI to fail now; let's just allow the problematic lint since it's in the pedantic category anyway.