-
-
Notifications
You must be signed in to change notification settings - Fork 35
chore!: bump deps, bump MSRV to 1.88 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps multiple Rust dependencies across the project, including a major version update for the askama templating library (0.14 → 0.15) and numerous other dependency updates reflected in Cargo.lock files. The PR also updates the minimum supported Rust version.
Key changes:
- Update minimum Rust version from 1.86 to 1.88
- Bump askama from 0.14 to 0.15 across all example projects and workspace
- Update numerous transitive dependencies in Cargo.lock files
- Change unused_qualifications lint from "warn" to "allow"
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/todo-list/Cargo.toml | Update askama dependency to 0.15 |
| examples/sessions/Cargo.toml | Update askama dependency to 0.15 |
| examples/forms/Cargo.toml | Update askama dependency to 0.15 |
| examples/file-upload/Cargo.toml | Update askama dependency to 0.15 |
| examples/custom-error-pages/Cargo.toml | Update askama dependency to 0.15 |
| examples/admin/Cargo.toml | Update askama dependency to 0.15 |
| cot-cli/src/project_template/Cargo.toml.template | Update askama dependency to 0.15 for project template |
| cot-cli/src/project_template/Cargo.lock.template | Update all transitive dependencies in project template lockfile |
| Cargo.toml | Update workspace dependencies (askama, bytes, clap, darling, http) and rust-version; change unused_qualifications lint |
| Cargo.lock | Update all transitive dependencies in main lockfile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| unstable_features = "warn" | ||
| unused_import_braces = "warn" | ||
| unused_qualifications = "warn" | ||
| unused_qualifications = "allow" |
Copilot
AI
Dec 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unused_qualifications lint is changed from "warn" to "allow". This relaxes the code quality requirements without explanation in the PR description. Consider documenting why this change is necessary or reverting it if it's not required by the dependency updates.
| unused_qualifications = "allow" | |
| unused_qualifications = "warn" |
|
| Branch | bump-deps-122025 |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,283.70 µs(+3.89%)Baseline: 6,048.32 µs | 6,800.87 µs (92.40%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,030.70 µs(+0.88%)Baseline: 1,021.74 µs | 1,130.83 µs (91.15%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 950.06 µs(+0.40%)Baseline: 946.28 µs | 1,044.96 µs (90.92%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 912.52 µs(+0.75%)Baseline: 905.71 µs | 997.29 µs (91.50%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 16,306.00 µs(-7.92%)Baseline: 17,709.07 µs | 21,033.28 µs (77.52%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.