Skip to content

feat: add FileStore implementation for cache (#427) #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achsanalfitra wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add FileStore implementation for cache (#427) #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
009cf2f
wip: implement file cache store
achsanalfitra Jan 20, 2026
96cbace
feat: change md5 to blake3 for hashing; remove md-5 dependency declar…
achsanalfitra Jan 20, 2026
959da28
feat: implement safe concurrent write with leftover cleanup during in…
achsanalfitra Jan 20, 2026
4b0489c
fix: error messages clarity
achsanalfitra Jan 20, 2026
cd74051
feat: implement locked temp file write version
achsanalfitra Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,2 @@
[resolver]
incompatible-rust-versions = "fallback"

# TODO: Safe to remove once https://github.com/rust-lang/rust/issues/141626 gets resolved.
# Also, see https://github.com/cot-rs/cot/pull/419/changes#r2636869773 for more info.
[target.x86_64-pc-windows-msvc]
linker = "rust-lld"
rustflags = ["-C", "symbol-mangling-version=v0"]
18 changes: 7 additions & 11 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ env:
SCCACHE_GHA_ENABLED: true
RUSTC_WRAPPER: sccache

_RUST_STABLE: &rust_stable stable
# Pinning the nightly version to a "stable" version to avoid CI breakages.
_RUST_NIGHTLY: &rust_nightly nightly-2025-11-11

# See: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#concurrency.
# This will ensure that only one commit will be running tests at a time on each PR.
concurrency:
Expand Down Expand Up @@ -62,9 +58,9 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]
include:
- rust: stable
version: *rust_stable
version: stable
- rust: nightly
version: *rust_nightly
version: nightly
- rust: MSRV
version: "1.88" # MSRV

Expand Down Expand Up @@ -153,7 +149,7 @@ jobs:
uses: dtolnay/rust-toolchain@master
with:
# cot_macros ui tests require nightly
toolchain: *rust_nightly
toolchain: nightly

- name: Cache Cargo registry
uses: Swatinem/rust-cache@v2
Expand Down Expand Up @@ -199,7 +195,7 @@ jobs:
uses: dtolnay/rust-toolchain@master
with:
# branch coverage is currently optional and requires nightly
toolchain: *rust_nightly
toolchain: nightly
components: llvm-tools-preview

- name: Reclaim disk space
Expand Down Expand Up @@ -252,7 +248,7 @@ jobs:
uses: dtolnay/rust-toolchain@master
with:
# nightly-only rustfmt settings
toolchain: *rust_nightly
toolchain: nightly
components: rustfmt

- name: Cache Cargo registry
Expand Down Expand Up @@ -303,7 +299,7 @@ jobs:
uses: dtolnay/rust-toolchain@master
with:
# the `-Z` flag is only accepted on the nightly channel of Cargo
toolchain: *rust_nightly
toolchain: nightly

- name: Cache Cargo registry
uses: Swatinem/rust-cache@v2
Expand Down Expand Up @@ -372,7 +368,7 @@ jobs:
uses: dtolnay/rust-toolchain@master
with:
# miri requires nightly
toolchain: *rust_nightly
toolchain: nightly
components: miri

- name: Cache Cargo registry
Expand Down
Loading