Conversation
There was a problem hiding this comment.
Pull request overview
Adds Serde support to the core Html newtype so it can be serialized/deserialized as a plain string (transparent newtype), aligning Html with other data types that can be passed through JSON or other Serde-based formats.
Changes:
- Import
serde::{Serialize, Deserialize}incot-core/src/html.rs. - Derive
SerializeandDeserializeforHtml. - Mark
Htmlas#[serde(transparent)]so it serializes identically to aString.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| Branch | html-serde |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 5,785.40 µs(-2.17%)Baseline: 5,913.99 µs | 7,047.89 µs (82.09%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,015.60 µs(-0.15%)Baseline: 1,017.11 µs | 1,159.76 µs (87.57%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 937.03 µs(-0.08%)Baseline: 937.75 µs | 1,064.06 µs (88.06%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 907.47 µs(+0.98%)Baseline: 898.68 µs | 1,021.85 µs (88.81%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 16,728.00 µs(-4.47%)Baseline: 17,510.63 µs | 20,719.94 µs (80.73%) |
HtmlHtml
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
No description provided.