fix(): resolve issue with <a> tag wrapping for <img>#2597
Open
njelich wants to merge 3 commits intocotes2020:masterfrom
Open
fix(): resolve issue with <a> tag wrapping for <img>#2597njelich wants to merge 3 commits intocotes2020:masterfrom
njelich wants to merge 3 commits intocotes2020:masterfrom
Conversation
cotes2020
reviewed
Jan 3, 2026
Owner
cotes2020
left a comment
cotes2020
left a comment
There was a problem hiding this comment.
Your changes indeed fixed the whitespace issue. However, it would be even better if you could also address the two other issues mentioned in this comment: #2596 (comment)
Author
|
Gotcha, will do it! I didn't spot them since I just wanted my site to work with what I needed. |
Owner
|
I have one more concern: in scenarios where an image link points to an external website, it shouldn't be opened with Glightbox. How can we distinguish these from regular images? |
Owner
|
Images on a web page can also use external URLs, such as: Given a website at [](https://b-site.com)In this case, relative paths are no longer sufficient to differentiate between triggering the lightbox and navigating the browser to an external site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixes the HTML generation to better handle whitespace, when wrapping![]()
tags with
Additional context
Fixes #2596