Add support for client certificate authentication#3
Merged
Conversation
Deprecate `Credential.ofDynamic()` because it is not compatible with client certificates. Add `Cluster.credential()` as the new way to update the credential used by the cluster.
programmatix
approved these changes
Jan 30, 2026
| this.queryExecutor = newQueryExecutor(this.options, this.url, this.credential); | ||
|
|
||
| // Don't close the old query executor, because we don't want to interfere with in-flight requests. | ||
| // The OkHttp resources automatically release themselves after a period of inactivity. |
There was a problem hiding this comment.
I was going to ask about what happens with old requests. This is neat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Credential.fromKeyStore() for client certificates
Deprecate
Credential.ofDynamic()because it is not compatible with client certificates.Add
Cluster.credential()as the new way to update the credential used by the cluster.