JCO-35 Expose an internal API for the JDBC driver to use#5
Merged
Conversation
Motivation ---------- The JDBC driver needs to make different HTTP requests than the standard Analytics SDK. Rather than expand the SDK's public API, we'll expose an internal low-level client the JDBC driver can use to execute custom HTTP requests. Modifications ------------- Add `InternalUnsupportedHttpClient` with methods for executing ad hoc HTTP requests and streaming query results. Use an interceptor to add the "Authorization" header, so all requests get authenticated regardless of code path. Extract `RawQueryMetadata` out of `AnalyticsResponseParser` to minimize the API surface area exposed to the JDBC driver. The internal methods that previously returned `QueryMetadata` now return `RawQueryMetadata` -- which has all the fields required by the JDBC driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The JDBC driver needs to make different HTTP requests than the standard Analytics SDK. Rather than expand the SDK's public API, we'll expose an internal low-level client the JDBC driver can use to execute custom HTTP requests.
Modifications
Add
InternalUnsupportedHttpClientwith methods for executing ad hoc HTTP requests and streaming query results.Use an interceptor to add the "Authorization" header, so all requests get authenticated regardless of code path.
Extract
RawQueryMetadataout ofAnalyticsResponseParserto minimize the API surface area exposed to the JDBC driver. The internal methods that previously returnedQueryMetadatanow returnRawQueryMetadata-- which has all the fields required by the JDBC driver.