CBD-6348: Fixes required to upgrade clang-analyze to clang-18.1.8

Change-Id: Id30db1722af1919b4e99d0009a55e8b8ad444066
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/235185
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Faizan Alam <[email protected]>
Well-Formed: Restriction Checker

Author: trondn

engines/default_engine/assoc.cc

@@ -172,17 +172,16 @@ static void assoc_expand() {
         return;
     }
 
-    int ret = 0;
     cb_thread_t tid;
 
     global_assoc->hashpower++;
     global_assoc->expanding = true;
     global_assoc->expand_bucket = 0;
 
     /* start a thread to do the expansion */
-    if ((ret = cb_create_named_thread(&tid, assoc_maintenance_thread,
-                                      nullptr, 1, "mc:assoc_maint")) != 0)
-    {
+    if (cb_create_named_thread(
+                &tid, assoc_maintenance_thread, nullptr, 1, "mc:assoc_maint") !=
+        0) {
         LOG_ERROR("Can't create thread for rebalance assoc table: {}",
                   cb_strerror());
         global_assoc->hashpower--;

engines/ep/src/connhandler.cc

@@ -340,19 +340,7 @@ void ConnHandler::addStats(const AddStatFn& add_stat, const CookieIface* c) {
         }
     }
     const auto priority = engine_.getDCPPriority(cookie);
-    const char* priString = "<INVALID>";
-    switch (priority) {
-    case ConnectionPriority::High:
-        priString = "high";
-        break;
-    case ConnectionPriority::Medium:
-        priString = "medium";
-        break;
-    case ConnectionPriority::Low:
-        priString = "low";
-        break;
-    }
-    addStat("priority", priString, add_stat, c);
+    addStat("priority", format_as(priority), add_stat, c);
     addStat(DcpControlKeys::FlatBuffersSystemEvents,
             areFlatBuffersSystemEventsEnabled(),
             add_stat,

engines/ep/tests/ep_testsuite_common.cc

@@ -68,7 +68,7 @@ TestCaseV2::TestCaseV2(const char *_name,
 engine_test_t* BaseTestCase::getTest() {
     engine_test_t *ret = &test;
 
-    std::string nm(name);
+    std::string nm(name == nullptr ? "" : name);
     std::stringstream ss;
 
     if (cfg != nullptr) {