CBD-6348: [BP] clang-analyze: initialization value is never read

Value stored to 'priString' during its initialization is never read

Use the utility function format_as instead

Change-Id: Id3971be90a70b3351ebaea51e535403c6603bc70
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/234821
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Pavlos Georgiou <[email protected]>
Well-Formed: Restriction Checker

Author: trondn

engines/ep/src/connhandler.cc

@@ -354,19 +354,7 @@ void ConnHandler::addStats(const AddStatFn& add_stat, CookieIface& c) {
         }
     }
     const auto priority = cookie.load()->getConnectionIface().getPriority();
-    const char* priString = "<INVALID>";
-    switch (priority) {
-    case ConnectionPriority::High:
-        priString = "high";
-        break;
-    case ConnectionPriority::Medium:
-        priString = "medium";
-        break;
-    case ConnectionPriority::Low:
-        priString = "low";
-        break;
-    }
-    addStat("priority", priString, add_stat, c);
+    addStat("priority", format_as(priority), add_stat, c);
     addStat(DcpControlKeys::FlatBuffersSystemEvents,
             areFlatBuffersSystemEventsEnabled(),
             add_stat,