[clang-tidy] Initialize all Cookie members

Some of the members in Cookie were not initialized as part
of the constructor (but still initialized before they where
used). Add initialization of the members as part of the
constructor to get rid of the warning.

Change-Id: I3709fb2af0df43be55b2ef27c9e0c7d6e55fedd4
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/201750
Tested-by: Build Bot <[email protected]>
Reviewed-by: Pavlos Georgiou <[email protected]>

Author: trondn

daemon/cookie.cc

@@ -440,7 +440,9 @@ void Cookie::maybeLogSlowCommand(
     }
 }
 
-Cookie::Cookie(Connection& conn) : connection(conn) {
+Cookie::Cookie(Connection& conn)
+    : connection(conn),
+      resource_allocation_domain(ResourceAllocationDomain::None) {
 }
 
 void Cookie::initialize(const cb::mcbp::Header& header, bool tracing_enabled) {

daemon/cookie.h

@@ -683,19 +683,19 @@ class Cookie : public CookieIface {
 
     /// The high resolution timer value for when we started throttling
     std::chrono::steady_clock::time_point throttle_start;
-    std::chrono::duration<int32_t, std::micro> total_throttle_time;
+    std::chrono::duration<int32_t, std::micro> total_throttle_time{};
 
     /// The location where we checked for available resources so that we
     /// update the correct throttling gauge
     ResourceAllocationDomain resource_allocation_domain;
 
     /// The per command read throttling factor (we might want to differentiate
     /// commands which have to do disk IO vs in-memory commands)
-    float read_thottling_factor;
+    float read_thottling_factor{};
 
     /// The per command write throttling factor (we might want to differentiate
     /// commands which have to do disk IO vs in-memory commands)
-    float write_thottling_factor;
+    float write_thottling_factor{};
 
     /**
      * The status for the async io operation