MB-42016: Increase detail in DroppedCollections exceptions

MB shows a throw from Manifest::DroppedCollections::remove,
yet the logging and debugger backtrace don't quite make sense.

Include a dump of the Manifest in the exception to see if we
can solve the issue with a reproduction.

Change-Id: Ia8f6a51c7e79b4a2793435c0a3248b9f16e8f097
Reviewed-on: http://review.couchbase.org/c/kv_engine/+/138086
Reviewed-by: Trond Norbye <[email protected]>
Tested-by: Jim Walker <[email protected]>

Author: jimwwalker

engines/ep/src/collections/flush.cc

@@ -17,6 +17,7 @@
 
 #include "collections/flush.h"
 #include "../kvstore.h"
+#include "bucket_logger.h"
 #include "collections/collection_persisted_stats.h"
 #include "collections/kvstore_generated.h"
 #include "collections/vbucket_manifest.h"
@@ -139,7 +140,16 @@ void Flush::postCommitMakeStatsVisible() {
 }
 
 void Flush::flushSuccess(Vbid vbid, KVBucket& bucket) {
-    notifyManifestOfAnyDroppedCollections();
+    try {
+        notifyManifestOfAnyDroppedCollections();
+    } catch (const std::exception& e) {
+        EP_LOG_CRITICAL(
+                "Flush notifyManifestOfAnyDroppedCollections caught exception "
+                "for {}",
+                vbid);
+        EP_LOG_CRITICAL("{}", e.what());
+        throw;
+    }
     checkAndTriggerPurge(vbid, bucket);
 }
 

engines/ep/src/collections/vbucket_manifest.cc

@@ -998,10 +998,13 @@ void Manifest::DroppedCollections::remove(CollectionID cid, uint64_t seqno) {
         // had items we created for a collection which is open or was open.
         // to not find the collection at all means we have flushed an item
         // to a collection that never existed.
-        throw std::logic_error(std::string(__PRETTY_FUNCTION__) +
+        std::stringstream ss;
+        ss << *this;
+        throw std::logic_error(std::string(__PRETTY_FUNCTION__) + ":" +
+                               std::to_string(__LINE__) +
                                " The collection cannot be found collection:" +
-                               cid.to_string() +
-                               " seqno:" + std::to_string(seqno));
+                               cid.to_string() + " seqno:" +
+                               std::to_string(seqno) + " " + ss.str());
     }
 
     auto& [key, vector] = *dropItr;
@@ -1023,9 +1026,14 @@ void Manifest::DroppedCollections::remove(CollectionID cid, uint64_t seqno) {
         return;
     }
 
-    throw std::logic_error(std::string(__PRETTY_FUNCTION__) +
-                           " The collection seqno cannot be found collection:" +
-                           cid.to_string() + " seqno:" + std::to_string(seqno));
+    std::stringstream ss;
+    ss << *this;
+
+    throw std::logic_error(std::string(__PRETTY_FUNCTION__) + ":" +
+                           std::to_string(__LINE__) +
+                           " The collection@seqno cannot be found collection:" +
+                           cid.to_string() + " seqno:" + std::to_string(seqno) +
+                           " " + ss.str());
 }
 
 StatsForFlush Manifest::DroppedCollections::get(CollectionID cid,