Skip to content

Conversation

@torcolvin
Copy link
Collaborator

cleanup/prep for active replicator tests in #7201

Created helper functions to write ActiveReplicator tests with less boilerplate.

CBG-4370 create a cancel context inside BlipSyncContext

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin requested a review from bbrks November 25, 2024 18:00
@torcolvin torcolvin force-pushed the CBG-4370-replicator-test-refactor branch from ae4acef to a7464b7 Compare November 26, 2024 01:36
@torcolvin torcolvin marked this pull request as draft November 26, 2024 02:08
@torcolvin
Copy link
Collaborator Author

Decided not to pursue this because t.Cleanup(http.Server.Close) will run after the defer for the rest tester, and this doesn't behave in predictable ways.

@torcolvin torcolvin closed this Nov 26, 2024
@torcolvin torcolvin deleted the CBG-4370-replicator-test-refactor branch November 26, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants