Skip to content

Conversation

@torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Mar 12, 2025

CBG-4562 do not return invalid sessions with GET /db/_user/{username}/_session

  • Fix the behavior of GET /db/_session to return not found when it encounters an invalid session by just returning NotFound when the session is present but invalid.
  • Change the behavior of GetSession to return an error when a session is not found to make the behavior of the function more obvious to avoid having to check for session == nil when err == nil.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin requested a review from adamcfraser March 12, 2025 15:39
@github-actions
Copy link

github-actions bot commented Mar 12, 2025

Redocly previews

@bbrks bbrks merged commit 4fe1928 into main Mar 14, 2025
47 checks passed
@bbrks bbrks deleted the CBG-4562 branch March 14, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants