Skip to content

Conversation

@torcolvin
Copy link
Collaborator

CBG-4604 document missing run states

  • update online/offline endpoints to discourage use vs /{db}/_config with offline in JSON.

This should probably be updated as well https://docs.couchbase.com/sync-gateway/current/resync.html#steps-to-resync and https://docs.couchbase.com/sync-gateway/current/database-offline.html

I think it is fine to POST to /{db}/_config even if you aren't using persistent config, but let me know if I misunderstand this and we need include the legacy way of doing online/offline.

I do not like the offline endpoint since

if atomic.CompareAndSwapUint32(&dc.State, DBOnline, DBStopping) {
doesn't close the feeds correctly since the ctx isn't cancelled 6317f19

- update online/offline endpoints to discourage use
@github-actions
Copy link

github-actions bot commented Apr 11, 2025

Redocly previews

Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on phrasing

@torcolvin torcolvin requested a review from bbrks April 15, 2025 19:06
@bbrks bbrks enabled auto-merge (squash) April 15, 2025 19:09
@bbrks bbrks merged commit a82bd93 into main Apr 16, 2025
48 of 49 checks passed
@bbrks bbrks deleted the CBG-4604 branch April 16, 2025 13:25
torcolvin added a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants