Skip to content

Conversation

@torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Aug 1, 2025

CBG-3778 remove rt.*Directly functions

  • change the REST functions to add CV property. Add ticket to write tests.

Integration Tests

ISGR doesn't yet support CV comparison, so switch those assertions to CV
only
@bbrks bbrks requested a review from Copilot August 6, 2025 12:35

This comment was marked as outdated.

@torcolvin torcolvin changed the title remove rt.*Directly functions CBG-3778 remove rt.*Directly functions Aug 8, 2025
@torcolvin torcolvin requested a review from Copilot August 8, 2025 12:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated rt.*Directly functions and refactors code to use REST API calls instead of direct database operations. The changes primarily involve switching test code from internal database operations to REST endpoints and adding support for Conflict Vectors (CV) in API responses.

Key changes:

  • Removes PutDocDirectly, UpdateDocDirectly, DeleteDocDirectly, and PutDocDirectlyInCollection functions
  • Updates API handlers to return CV (Conflict Vector) information in responses
  • Adds stub functions WaitForRevTreeVersion and WaitForRevTreeTombstone for rev tree version checking until ISGR supports CV
  • Refactors numerous test files to use REST API calls instead of direct database operations

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rest/utilities_testing_resttester.go Removes direct database operation methods and adds CV support helpers
rest/utilities_testing.go Updates response parsing to include CV extraction
rest/doc_api.go Adds CV to PUT, DELETE, and attachment API responses
rest/revocation_test.go Converts from direct DB calls to REST API calls
rest/replicatortest/replicator_test.go Updates test methods and adds temporary test skip
rest/importtest/import_test.go Converts direct DB operations to REST calls
rest/doc_api_test.go Updates tests to use REST API and adds CV validation
rest/changestest/changes_api_test.go Converts direct update to REST API call
rest/bootstrap_test.go Updates response validation to handle CV
Multiple BLIP test files Converts from direct DB operations to REST API calls

@bbrks
Copy link
Member

bbrks commented Aug 21, 2025

Should be done by #7697

@bbrks bbrks closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants