-
Notifications
You must be signed in to change notification settings - Fork 140
CBG-3778 remove rt.*Directly functions #7658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ISGR doesn't yet support CV comparison, so switch those assertions to CV only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated rt.*Directly functions and refactors code to use REST API calls instead of direct database operations. The changes primarily involve switching test code from internal database operations to REST endpoints and adding support for Conflict Vectors (CV) in API responses.
Key changes:
- Removes
PutDocDirectly,UpdateDocDirectly,DeleteDocDirectly, andPutDocDirectlyInCollectionfunctions - Updates API handlers to return CV (Conflict Vector) information in responses
- Adds stub functions
WaitForRevTreeVersionandWaitForRevTreeTombstonefor rev tree version checking until ISGR supports CV - Refactors numerous test files to use REST API calls instead of direct database operations
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
rest/utilities_testing_resttester.go |
Removes direct database operation methods and adds CV support helpers |
rest/utilities_testing.go |
Updates response parsing to include CV extraction |
rest/doc_api.go |
Adds CV to PUT, DELETE, and attachment API responses |
rest/revocation_test.go |
Converts from direct DB calls to REST API calls |
rest/replicatortest/replicator_test.go |
Updates test methods and adds temporary test skip |
rest/importtest/import_test.go |
Converts direct DB operations to REST calls |
rest/doc_api_test.go |
Updates tests to use REST API and adds CV validation |
rest/changestest/changes_api_test.go |
Converts direct update to REST API call |
rest/bootstrap_test.go |
Updates response validation to handle CV |
| Multiple BLIP test files | Converts from direct DB operations to REST API calls |
|
Should be done by #7697 |
CBG-3778 remove rt.*Directly functions
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/3247/ (known flakes)