Conversation
Redocly previews |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive support for Current Versions (CVs) in bulk APIs by removing the show_cv parameter and always returning CV values, similar to other APIs. The changes enable bulk APIs to accept both RevTree IDs and CVs for document operations.
Key changes:
- Removed
show_cvquery parameter from_all_docsand_bulk_getAPIs - CVs are now always returned - Enhanced
_bulk_getto accept either RevTree IDs or CVs in therevfield via renamed variablerevOrCV - Updated
_bulk_docsto return both RevTree ID and CV in responses for regular documents
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rest/bulk_api.go | Core implementation removing show_cv parameters and adding CV support to bulk operations |
| rest/utilities_testing_resttester.go | Updated GetDoc helper to handle documents without CV (like local docs) |
| rest/api_test.go | Enhanced TestBulkDocs with comprehensive CV/RevTree ID testing and removed hardcoded responses |
| rest/doc_api_test.go | Expanded TestBulkGetWithCV with additional test cases for CV/RevTree ID handling |
| rest/role_api_test.go | Updated test assertions to handle dynamic CV values in responses |
| rest/access_test.go | Modified test expectations to accommodate CV inclusion in responses |
| rest/adminapitest/admin_api_test.go | Updated rev tree test to handle dynamic CV values |
| docs/api/ | Removed show_cv parameter from OpenAPI specifications for affected endpoints |
torcolvin
reviewed
Aug 28, 2025
torcolvin
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-4752
Read and write support for CVs in bulk APIs:
_all_docsshow_cvoption. Always return CV like we do for other APIs._bulk_getshow_cvoption.revOrCV)_bulk_docsIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGatewayIntegration/55/