Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the go2xunit tool with gotestsum for test execution and JUnit XML report generation in both the main Jenkins pipeline and integration build scripts. The change aims to modernize the testing infrastructure and improve test reporting capabilities.
Key changes:
- Replace
go2xunitwithgotestsumfor JUnit XML generation - Simplify test execution by integrating XML output directly into test commands
- Remove manual post-processing steps for cleaning test output
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| jenkins-integration-build.sh | Replaces go2xunit installation and usage with gotestsum, removes manual XML generation steps |
| Jenkinsfile | Updates main pipeline to use gotestsum for both CE and EE unit tests, simplifies test execution logic |
| .editorconfig | Adds shell script formatting configuration (unrelated to main changes) |
9a32b17 to
d9e0a27
Compare
26222ed to
0a23407
Compare
bbrks
approved these changes
Sep 19, 2025
Member
bbrks
left a comment
There was a problem hiding this comment.
LGTM 👍 great QoL change with the fixed "failed log output" as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-4852 replace go2xunit with gotestsum
This should prevent the errors we see where go2xunit crashes:
gotestsumto produce junit output, which is natively parsed by jenkins--suite-name-prefix--junitfile-project-nameto force jenkins to not collapse matching test results together. This isn't visible externally but just used jenkins junit pluginscriptblock to Jenkinsfile to allow capturing error codes fromshcommand as a groovy variable instead of relying on parsing an output fileNormal Jenkins integration test output (stays the same):
https://jenkins.sgwdev.com/job/SyncGatewayIntegration/91/
Example of pipeline failures (with CE/EE, like main):
https://jenkins.sgwdev.com/job/Pipeline/view/change-requests/job/PR-7766/3/
Example of integration test failure:
https://jenkins.sgwdev.com/job/gotestsum-expr/18/