Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR creates new patch releases for Couchbase Sync Gateway versions 4.0.0.2 and 3.3.0.2, adding configuration entries and manifest files for these releases.
- Added configuration entries for new patch releases 4.0.0.2 and 3.3.0.2
- Created manifest files for the previous patch versions (4.0.0.1 and 3.3.0.1)
- Updated main manifest files to point to the new patch releases
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| manifest/product-config.json | Added configuration entries for 3.3.0.1 and 4.0.0.1, updated 4.0.0.xml to reference 4.0.0.2 |
| manifest/4.0/4.0.0.1.xml | New manifest file for version 4.0.0.1 with specific commit revision |
| manifest/4.0.xml | Updated VERSION annotation and sync_gateway revision to 4.0.0.2 |
| manifest/3.3/3.3.0.1.xml | New manifest file for version 3.3.0.1 with specific commit revision |
| manifest/3.3.xml | Updated VERSION annotation and sync_gateway revision to 3.3.0.2 |
manifest/product-config.json
Outdated
| "go_version": "1.24.4", | ||
| "interval": 1440, | ||
| "production": true, | ||
| "release": "4.0.0", |
There was a problem hiding this comment.
The release version should be '4.0.0.1' to match the release_name and the file path. Currently it's set to '4.0.0' which is inconsistent.
Suggested change
| "release": "4.0.0", | |
| "release": "4.0.0.1", |
adamcfraser
requested changes
Oct 29, 2025
manifest/product-config.json
Outdated
Collaborator
There was a problem hiding this comment.
Shouldn't this be updated to 3.3.0.2?
adamcfraser
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.