Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR converts the change cache's locking mechanism from a read-write mutex (sync.RWMutex) to an exclusive mutex (sync.Mutex). This change simplifies the locking strategy by treating all operations uniformly, potentially addressing concurrency issues at the cost of some read concurrency. The team plans to evaluate performance impacts and may revert if there are regressions.
Key Changes:
- Replaced
sync.RWMutexwithsync.Mutexin thechangeCachestruct - Updated read lock calls (
RLock()/RUnlock()) to exclusive lock calls (Lock()/Unlock())
Member
|
As discussed will just park this until we have a good perf baseline to measure against then decide whether to do it or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5049
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGatewayIntegration/203/