Skip to content

Various fixes for three CBL tickets #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pasin merged 10 commits into from
Dec 4, 2024
Merged

Various fixes for three CBL tickets #103

pasin merged 10 commits into from
Dec 4, 2024

Conversation

@borrrden
Copy link
Member

@borrrden borrrden commented Dec 3, 2024 •
edited
Loading

As well as other things that came up during making the fixes or otherwise:

  • Add trailing slash to a few SGW endpoints so it doesn't require a needless HTTP redirect
  • Fix the Windows .NET test server from having issues with install by not having external dependencies in the packaging process
  • Skip a failing test pending a CBG issue outcome
  • Fix .NET server not sending verbose logs anywhere
  • Turn on Sync Gateway file logging
  • Optimize Sync Gateway Dockerfile so that the deb is downloaded as one of the first steps. This makes config changes much faster since the download will have been cached as a previous step

@borrrden borrrden requested review from bmeike and pasin December 3, 2024 02:26
@pasin pasin merged commit 2557977 into main Dec 4, 2024
1 check passed
@pasin pasin deleted the fix/various branch December 4, 2024 03:48
pasin pushed a commit that referenced this pull request Dec 4, 2024
@borrrden
Various fixes for three CBL tickets (#103)
0906e48 
* CBL-6493: Updating bulk_docs needs to use legacy revID for now

* CBL-6492: Deleting docs in SGW needs to use legacy revid for now

* CBL-6519: Don't infinitely retry put database 500 error

* Trailing slash to prevent needless HTTP 301

* Fix for not being able to reliably install .NET server

* TDK side fixes for CBL-6497

The test still fails and will be skipped pending a CBG bug outcome

* Fix verbose logging in .NET server

* Enable SGW file logging and optimize Dockerfile

* mypy detected a bunch of goofs

Most revolving around the fact that revid is now nullable when it wasn't before

* Install types package in github workflow

for "Deprecated" package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasin pasin pasin approved these changes

+1 more reviewer

@bmeike bmeike bmeike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@borrrden @bmeike @pasin