Conversation
borrrden
left a comment
borrrden
left a comment
There was a problem hiding this comment.
This would be a bit more robust if you did not hard code the log path. You can pull the logging directory from the SG config first to know where it is without hard coding.
RIT3shSapata
left a comment
RIT3shSapata
left a comment
There was a problem hiding this comment.
Similar observations as PR #294 . Please create a sync function that assigns the channel to the documents and use the Public API to get the documents using the created user. Currently the all_docs endpoint is accessed via the Admin API which would use Adminstrator user instead of vipul user. This test still passes because all the users are redacted.
vipbhardwaj
changed the title
…ality which was merged in the previous PR
vipbhardwaj
force-pushed
the
test_log_redaction_partial
branch
from
fe1a87c to
f44b68b
Compare
|
Hey @borrrden , @RIT3shSapata This is the one and only flaw of having smaller multiple PRs I feel 😢 |
|
Don't worry about having lots of commits in a PR, they will be squashed anyway |
client/pyproject.toml
Outdated
| "types-requests==2.32.0.20241016", | ||
| "types-netifaces==0.11.0.20241025" | ||
| "types-netifaces==0.11.0.20241025", | ||
| "types-paramiko" |
There was a problem hiding this comment.
This should have a pinned version
There was a problem hiding this comment.
It was rejecting pinned versions, I tried with 2 different valid versions but I kept getting the error :
× No solution found when resolving dependencies:
╰─▶ Because there is no version of types-paramiko==3.5.0.20241016 and
cbltest[dev]==1.2.2 depends on types-paramiko==3.5.0.20241016, we can
conclude that cbltest[dev]==1.2.2 cannot be used.
And because only cbltest[dev]==1.2.2 is available and you require
cbltest[dev], we can conclude that your requirements are unsatisfiable.
There was a problem hiding this comment.
Can you point me to a pinned version that would work?
There was a problem hiding this comment.
What version gets installed when you just install it normally? I usually copy that. The latest 3.5.0 for that is 3.5.0.20250801 though
…old tests too, was erased due to the rebase 12hrs ago
3 participants
This test is a step by step migration of the this test in the old framework.
This function tests Sync Gateway's log redaction feature. It configures Sync Gateway with different logging levels and verifies that sensitive data is tagged appropriately ('ud' tags for partial) when log redaction is enabled. The test creates a user, adds documents with xattrs, and checks the logs for the correct tagging based on the configured redaction level.