Conversation
borrrden
left a comment
There was a problem hiding this comment.
In addition the sync gateway class I think needs some more thinking (messaged offline)
|
I've addressed the issues in the sub-comments, as to the SGW related parent comment issue, I am working on it and will merge the appropriate code in the PR#322 : sgw-refactoring |
borrrden
left a comment
There was a problem hiding this comment.
Let's start with this. Also this PR has a bunch of sync gateway changes. If they are needed lets focus on the other PR first which is for those changes.
85a3d74 to
efb6d5b
Compare
|
I resolved the merge conflicts since the #306 got merged and now I think this PR is ripe to be merged too 🍓 ✅ |
|
@borrrden @RIT3shSapata I've added another test to the same file hence requesting reviews again. TDK changes :
TEST changes :Added a test for collection based mapping across clusters. |
RIT3shSapata
left a comment
There was a problem hiding this comment.
The tests look good, I just have a few nits about the description of the tests and code cleanliness
|
Guys please give a final review for this please 😢 |
The test being migrated is this
There are a lot of changes to the infra to support the multi-CBS topology, and I have changed the SGW topology.json to have 2 cbs' as well.
There are some changes to have both Private and Public IP to be served based on the need, since TDK requires to communicate via Public IP but some APIs use Private IP and the SGW <-> CBS comunication happens via private IP since they are a part of the same VPC in AWS up there. ☁️
I've also added a miniscule change of reducing the num_docs of test_purge fromm 1000 -> 100, to match the others, and after the continuous pain that it, unlike the other tests, takes more than half an hour due to 10x the docs to jiggle with.