migrated load balancer tests and topology to include the same#335
Merged
vipbhardwaj merged 12 commits intomainfrom Jan 29, 2026
Merged
migrated load balancer tests and topology to include the same#335vipbhardwaj merged 12 commits intomainfrom
vipbhardwaj merged 12 commits intomainfrom
Conversation
RIT3shSapata
suggested changes
Dec 9, 2025
RIT3shSapata
left a comment
RIT3shSapata
left a comment
There was a problem hiding this comment.
I did not quite understand what the test test_sgw_down_with_load_balancer is doing, is there any older test that I can reference? We can discuss this further offline as well
This was referenced Dec 15, 2025
Closed
Member
|
There is also no test spec for this test. |
vipbhardwaj
force-pushed
the
sgw-loadbalancer-tests
branch
from
fb7df2c to
5cd5d6a
Compare
Closed
borrrden
requested changes
Jan 21, 2026
* Added CBS shell2http scripts * Flaky test, redundant? needs fixing * test run functionality minimalized * Ruff format fix post github web conflict resolve
borrrden
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added the load balancer tests. No other changes in API files. No changes in anything else except topology which now has load balancers.