Skip to content

Conversation

@rakhi-prathap
Copy link
Contributor

Adds two new flags to the EXTRACTDDL function.

Jira: DOC-13700
Docs preview: EXTRACTDDL()
Preview credentials: Credentials for internal review

Note

These flags are supported only starting with the 8.0.1 update, so DO NOT MERGE until that version is available.

Copy link

@Sohoxic Sohoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the function and prepareds flag but just a suggestion if you could add another example where we donot specify the flags, meaning an empty "" which will give back all the DDL statements(create bucket/scope/collection/index/sequence/function/prepareds). Also if you could add examples for each of the flag separately like we have for index:

SELECT extractddl("travel-sample",{"flags":["index"]});

Else everything looks fine to me!

* CREATE COLLECTION
* CREATE INDEX
* CREATE SEQUENCE
* CREATE FUNCTION [.status]#Couchbase Server 8.0.1#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency

Suggested change
* CREATE FUNCTION [.status]#Couchbase Server 8.0.1#
* CREATE OR REPLACE FUNCTION [.status]#Couchbase Server 8.0.1#


Accepts either a numeric value or an array of strings, but not both.

[options="header", cols="1a,1a,1a"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make third column narrower?

Suggested change
[options="header", cols="3a,2a,1a"]

[options="header", cols="1a,1a,1a"]
!===

! Statement ! String Value ! Numeric Value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
! Statement ! String ! Number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants