Skip to content

fix window.ts#36

Open
Andrii727 wants to merge 1 commit intocoulombjs:masterfrom
Andrii727:master
Open

fix window.ts#36
Andrii727 wants to merge 1 commit intocoulombjs:masterfrom
Andrii727:master

Conversation

@Andrii727
Copy link

Add ContextIsolation to BrowserWindow.

@strogonoff
Copy link
Collaborator

When testing this PR, I get the following when trying to run yarn:

[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
[1/6] ⠐ keytar
[2/6] ⠐ fsevents
[6/6] ⠐ electron
[-/6] ⠐ waiting...
error /Volumes/ITUOB/coulomb/node_modules/electron: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /Volumes/ITUOB/coulomb/node_modules/electron
Output:
HTTPError: Response code 404 (Not Found)
    at EventEmitter.<anonymous> (/Volumes/ITUOB/coulomb/node_modules/got/source/as-stream.js:35:24)
    at EventEmitter.emit (node:events:513:28)
    at module.exports (/Volumes/ITUOB/coulomb/node_modules/got/source/get-response.js:22:10)
    at ClientRequest.handleResponse (/Volumes/ITUOB/coulomb/node_modules/got/source/request-as-event-emitter.js:155:5)
    at Object.onceWrapper (node:events:628:26)
    at ClientRequest.emit (node:events:525:35)
    at origin.emit (/Volumes/ITUOB/coulomb/node_modules/@szmarczak/http-timer/source/index.js:37:11)

My Node version is 18.12.1, platform is arm64 (Apple Silicon)

@strogonoff
Copy link
Collaborator

after the above error, I get more output:

arning Error running install script for optional dependency: "/Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents: Command failed.                       19:00:46 [15/129]
Exit code: 1
Command: node install
Arguments:
Directory: /Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents
Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.12.0
node-pre-gyp info using node@18.12.1 | darwin | arm64
node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp info check checked for \"/Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents/lib/binding/Release/node-v108-darwin-arm64/fse.node\" (not found)
node-pre-gyp http GET https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.9/fse-v1.2.9-node-v108-darwin-arm64.tar.gz
node-pre-gyp http 404 https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.9/fse-v1.2.9-node-v108-darwin-arm64.tar.gz
node-pre-gyp WARN Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.9/fse-v1.2.9-node-v108-darwin-arm64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for fsevents@1.2.9 and node@18.12.1 (node-v108 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp http 404 status code downloading tarball https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.9/fse-v1.2.9-node-v108-darwin-arm64.tar.gz
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@18.12.1 | darwin | arm64
gyp info ok
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@18.12.1 | darwin | arm64
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable \"python\", you can set the PYTHON env variable.
gyp ERR! stack     at PythonFinder.failNoPython (/Volumes/ITUOB/coulomb/node_modules/node-gyp/lib/configure.js:484:19)
gyp ERR! stack     at PythonFinder.<anonymous> (/Volumes/ITUOB/coulomb/node_modules/node-gyp/lib/configure.js:406:16)
gyp ERR! stack     at F (/Volumes/ITUOB/coulomb/node_modules/which/which.js:68:16)
gyp ERR! stack     at E (/Volumes/ITUOB/coulomb/node_modules/which/which.js:80:29)
gyp ERR! stack     at /Volumes/ITUOB/coulomb/node_modules/which/which.js:89:16
gyp ERR! stack     at /Volumes/ITUOB/coulomb/node_modules/isexe/index.js:42:5
gyp ERR! stack     at /Volumes/ITUOB/coulomb/node_modules/isexe/mode.js:8:5
gyp ERR! stack     at FSReqCallback.oncomplete (node:fs:207:21)
gyp ERR! System Darwin 24.1.0
gyp ERR! command \"/Volumes/Ops/Setup/SW/NodeJS/node-v18.12.1-darwin-arm64/bin/node\" \"/Volumes/ITUOB/coulomb/node_modules/node-gyp/bin/node-gyp.js\" \"configure\" \"--fallback-to-build\" \"--modu
le=/Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents/lib/binding/Release/node-v108-darwin-arm64/fse.node\" \"--module_name=fse\" \"--module_path=/Volumes/ITUOB/coulomb/n
ode_modules/watchpack-chokidar2/node_modules/fsevents/lib/binding/Release/node-v108-darwin-arm64\" \"--napi_version=8\" \"--node_abi_napi=napi\" \"--napi_build_version=0\" \"--node_napi_label=node-
v108\"
gyp ERR! cwd /Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents
gyp ERR! node -v v18.12.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/Volumes/Ops/Setup/SW/NodeJS/node-v18.12.1-darwin-arm64/bin/node /Volumes/ITUOB/coulomb/node_modules/node-gyp/bin/node-gyp.js configure --fallback-
to-build --module=/Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents/lib/binding/Release/node-v108-darwin-arm64/fse.node --module_name=fse --module_path=/Volumes/ITUOB/co
ulomb/node_modules/watchpack-chokidar2/node_modules/fsevents/lib/binding/Release/node-v108-darwin-arm64 --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v108' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
node-pre-gyp ERR! stack     at maybeClose (node:internal/child_process:1091:16)
node-pre-gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:302:5)
node-pre-gyp ERR! System Darwin 24.1.0
node-pre-gyp ERR! command \"/Volumes/Ops/Setup/SW/NodeJS/node-v18.12.1-darwin-arm64/bin/node\" \"/Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents/node_modules/node-pre-
gyp/bin/node-pre-gyp\" \"install\" \"--fallback-to-build\"
node-pre-gyp ERR! cwd /Volumes/ITUOB/coulomb/node_modules/watchpack-chokidar2/node_modules/fsevents
node-pre-gyp ERR! node -v v18.12.1```

@strogonoff
Copy link
Collaborator

strogonoff commented Dec 9, 2024

I could run yarn with --ignore-scripts, and run the prepublish script after that successfully. However, I am unable to run yarn cdist in ITUOE app (discussing under ituob/itu-ob-editor#128 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants