Document lint warning recommendations and add follow-up issue proposal series#1902
Merged
pmcelhaney merged 5 commits intomainfrom Apr 16, 2026
Merged
Document lint warning recommendations and add follow-up issue proposal series#1902pmcelhaney merged 5 commits intomainfrom
pmcelhaney merged 5 commits intomainfrom
Conversation
Closed
Copilot
AI
changed the title
[WIP] Review lint warnings and provide recommendations
Document recommendations for current ESLint warning rules
Apr 16, 2026
pmcelhaney
requested changes
Apr 16, 2026
Collaborator
pmcelhaney
left a comment
There was a problem hiding this comment.
Create a series of issues that will collectively address all of the warnings.
Agent-Logs-Url: https://github.com/counterfact/api-simulator/sessions/0b2292ec-d93d-45f6-a331-97f8834b46ba Co-authored-by: pmcelhaney <51504+pmcelhaney@users.noreply.github.com>
Agent-Logs-Url: https://github.com/counterfact/api-simulator/sessions/0b2292ec-d93d-45f6-a331-97f8834b46ba Co-authored-by: pmcelhaney <51504+pmcelhaney@users.noreply.github.com>
Contributor
Author
Added a full issue-proposal series under |
Copilot
AI
changed the title
Document recommendations for current ESLint warning rules
Document lint warning recommendations and add follow-up issue proposal series
Apr 16, 2026
pmcelhaney
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed current ESLint warnings, documented a recommendation per warning rule, and added a proposal series under
.github/issue-proposals/so CI can create follow-up issues that collectively address all warning categories.Original Prompt
Review lint warnings and make a recommendation for each rule:
Manual acceptance tests
yarn lintand verify warnings are still grouped under 8 rule IDs.docs/development/lint-warning-recommendations.mdand verify each warning rule has one explicit recommendation (disable / fix / selectively fix-or-ignore)..github/issue-proposals/contains one new proposal file per warning rule category with valid front matter and non-empty body.parentIssue: 1901and an acceptance-criteria checklist.Tasks
/docs/development/lint-warning-recommendations.mdas the canonical recommendation artifact..github/issue-proposals/covering all warning rule categories.parentIssue: 1901.