Skip to content

Document lint warning recommendations and add follow-up issue proposal series#1902

Merged
pmcelhaney merged 5 commits intomainfrom
copilot/review-lint-warnings
Apr 16, 2026
Merged

Document lint warning recommendations and add follow-up issue proposal series#1902
pmcelhaney merged 5 commits intomainfrom
copilot/review-lint-warnings

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

Summary

Reviewed current ESLint warnings, documented a recommendation per warning rule, and added a proposal series under .github/issue-proposals/ so CI can create follow-up issues that collectively address all warning categories.

Original Prompt

Review lint warnings and make a recommendation for each rule:

  1. Disable it.
  2. Fix violations.
  3. Selectively fix or ignore violations.

Manual acceptance tests

  • Run yarn lint and verify warnings are still grouped under 8 rule IDs.
  • Open docs/development/lint-warning-recommendations.md and verify each warning rule has one explicit recommendation (disable / fix / selectively fix-or-ignore).
  • Confirm .github/issue-proposals/ contains one new proposal file per warning rule category with valid front matter and non-empty body.
  • Confirm each new proposal includes parentIssue: 1901 and an acceptance-criteria checklist.

Tasks

  • Baseline warning inventory
    • Collected current lint warnings and grouped by rule ID/count.
  • Recommendation mapping
    • Classified each rule into one of: disable, fix, selectively fix-or-ignore.
    • Added concise rationale tied to current warning patterns.
  • Documentation
    • Added /docs/development/lint-warning-recommendations.md as the canonical recommendation artifact.
    • Added a short priority order for follow-up implementation.
  • Issue proposal follow-up from PR feedback
    • Added a series of issue proposals under .github/issue-proposals/ covering all warning rule categories.
    • Used required YAML front matter and linked proposals to parentIssue: 1901.
    • Cleaned formatting so proposal files pass automated review checks.

Copilot AI linked an issue Apr 16, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Review lint warnings and provide recommendations Document recommendations for current ESLint warning rules Apr 16, 2026
Copilot AI requested a review from pmcelhaney April 16, 2026 13:14
Copy link
Copy Markdown
Collaborator

@pmcelhaney pmcelhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a series of issues that will collectively address all of the warnings.

Copilot AI and others added 2 commits April 16, 2026 13:59
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 16, 2026

Create a series of issues that will collectively address all of the warnings.

Added a full issue-proposal series under .github/issue-proposals/, covering all lint warning rules with parent linkage to #1901 and acceptance checklists. Main commit: 01dea73 (formatting cleanup in 531fa1e).

Copilot AI changed the title Document recommendations for current ESLint warning rules Document lint warning recommendations and add follow-up issue proposal series Apr 16, 2026
Copilot AI requested a review from pmcelhaney April 16, 2026 14:04
@pmcelhaney pmcelhaney marked this pull request as ready for review April 16, 2026 14:08
@pmcelhaney pmcelhaney enabled auto-merge April 16, 2026 14:09
@pmcelhaney pmcelhaney added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit a59d71b Apr 16, 2026
7 of 8 checks passed
@pmcelhaney pmcelhaney deleted the copilot/review-lint-warnings branch April 16, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review lint warnings

2 participants