Added instructions for downloading subtitles in README#530
Open
bandupahile wants to merge 4 commits intocoursera-dl:masterfrom
Open
Added instructions for downloading subtitles in README#530bandupahile wants to merge 4 commits intocoursera-dl:masterfrom
bandupahile wants to merge 4 commits intocoursera-dl:masterfrom
Conversation
adjust the name input of the SubSection to the new HTML structure
Updating from main repo
Added simple scripts for downloading subtitles for some common scenarios.
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨Please review the guidelines for contributing to this repository.
Proposed changes
I have added instructions in README for downloading subtitles during/after the course has been downloaded. This is in response to a suggestion by @rbrito in #524
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
--
Reviewers
@rbrito