Skip to content

Adding support for mathesis platform#548

Open
zafos wants to merge 2 commits intocoursera-dl:masterfrom
zafos:mathesis-support
Open

Adding support for mathesis platform#548
zafos wants to merge 2 commits intocoursera-dl:masterfrom
zafos:mathesis-support

Conversation

@zafos
Copy link

@zafos zafos commented May 31, 2019

Proposed changes

This patch is adding support for the mathesis platform of university of Crete. Unfortunately the lectures and website are in Greek, so I had to remove the ascii filename sanitisation for that case, otherwise any greek letters would get dropped. I've done the same for folder names, but in general not sure whether this is the ideal way to proceed.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.

Reviewers

If you know the person who can review your code please add a @mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant