Skip to content

small changes to parsing.py to address issue #559 #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mor3dr3ad wants to merge 2 commits into
base: master
Choose a base branch
from
Open

small changes to parsing.py to address issue #559 #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5b706d
Update parsing.py to account for new edx structure
mor3dr3ad Nov 6, 2019
006045f
update parsing.py to account for new edx structure
mor3dr3ad Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions edx_dl/parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def _get_section_name(section_soup): # FIXME: Extract from here and test

def _make_subsections(section_soup):
try:
subsections_soup = section_soup.find_all('li', class_='vertical outline-item focusable')
subsections_soup = section_soup.find_all('li', class_=['vertical outline-item focusable', 'vertical outline-item focusable scored'])
except AttributeError:
return []
# FIXME correct extraction of subsection.name (unicode)
Expand All @@ -394,7 +394,7 @@ def _make_subsections(section_soup):
return subsections

soup = BeautifulSoup(page)
sections_soup = soup.find_all('li', class_='outline-item section')
sections_soup = soup.find_all('li', class_=['outline-item section', 'outline-item section scored'])

sections = [Section(position=i,
name=_get_section_name(section_soup),
Expand Down