add additional run parameters for manifest.json#52
Open
alex-fddz wants to merge 1 commit intocoursera:masterfrom
Open
add additional run parameters for manifest.json#52alex-fddz wants to merge 1 commit intocoursera:masterfrom
alex-fddz wants to merge 1 commit intocoursera:masterfrom
Conversation
I don't work for Coursera, but I think Coursera provided these scripts for local testing only, so any changes you propose won't be reflected on their platform. I would guess that they will not allow privileged containers to run on their host, but who knows? If you have a support representative at Coursera, they should be able to help you or discuss what you're trying to implement. |
Author
|
I see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to specify additional
docker runparameters in the image directories' manifest.json as follows:This enables more flexibility, for instance, one can add the parameter
--hostnameand set its value.I am making this PR because my Lab uses a program that requires the docker container to be run with the
--privilegedparameter. I would like to have this running in the platform.BTW, I also fixed the variable name in the for loop for Manifest.environment_vars (previously set as mountData).