Skip to content

rename autocomplete component dismissLabel to dismissAriaLabel to aign with modal props #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
couvq merged 1 commit into from
Aug 17, 2025
Merged

rename autocomplete component dismissLabel to dismissAriaLabel to aign with modal props #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/flourish-rapid/src/components/examplePages/AutocompletePage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const AutocompletePage = () => {
<Typography data-testId="basic-autocomplete-selected-id">Selected id is {majorId}</Typography>
<Autocomplete
label="Pick a major"
dismissLabel='Clear input'
dismissAriaLabel='Clear input'
onSelectionChange={onSelectionChange}
data-testId="basic-autocomplete"
>
Expand Down
8 changes: 4 additions & 4 deletions packages/flourish-ui/src/components/Autocomplete/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ export interface AutocompleteProps<T extends object>
label: string
/** Whether to display the label, if false will attach the label with aria-label. */
isLabelVisible?: boolean
/** Accessible label for the component's clear button. */
dismissLabel: string
/** Label of the clear icon button for assistive technologies. */
dismissAriaLabel: string
}

export interface AutocompleteItemProps
Expand All @@ -37,7 +37,7 @@ export const AutocompleteItem = ({
export const Autocomplete = <T extends object>({
label,
isLabelVisible = true,
dismissLabel,
dismissAriaLabel,
children,
'data-testId': testId,
...props
Expand Down Expand Up @@ -70,7 +70,7 @@ export const Autocomplete = <T extends object>({
{inputValue.length > 0 && (
<Button
className="f-searchbar-clear-btn"
label={dismissLabel}
label={dismissAriaLabel}
variant="icon"
icon="close"
onClick={onDelete}
Expand Down