typesafety

Author: louis-bompart

packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts

@@ -229,7 +229,7 @@ export class AtomicCommerceSearchBox
       return;
     }
     if (
-      !Object.hasOwn(this.searchBoxState, 'redirectTo') ||
+      !this.isStandaloneSearchboxState(this.searchBoxState) ||
       !Object.hasOwn(this.searchBox, 'afterRedirection')
     ) {
       return;
@@ -309,6 +309,12 @@ export class AtomicCommerceSearchBox
     return Object.hasOwn(searchBox, 'updateRedirectUrl');
   }
 
+  private isStandaloneSearchboxState(
+    state: SearchBoxState | StandaloneSearchBoxState
+  ): state is StandaloneSearchBoxState {
+    return Object.hasOwn(this.searchBoxState, 'redirectTo');
+  }
+
   private updateBreakpoints = once(() => updateBreakpoints(this));
 
   private get isSearchDisabledForEndUser() {

packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx

@@ -212,6 +212,11 @@ export class AtomicSearchBox implements InitializableComponent<Bindings> {
   @AriaLiveRegion('search-suggestions', true)
   protected suggestionsAriaMessage!: string;
 
+  private isStandaloneSearchBoxState(): this is (AtomicSearchBox & {
+    searchBoxState: StandaloneSearchBoxState}) {
+    return Object.hasOwn(this.searchBoxState, 'redirectTo');
+    }
+
   private isStandaloneSearchBox(
     searchBox: SearchBox | StandaloneSearchBox
   ): searchBox is StandaloneSearchBox {
@@ -252,9 +257,13 @@ export class AtomicSearchBox implements InitializableComponent<Bindings> {
         });
   }
 
+  private isStandaloneSearchboxState(state: SearchBoxState | StandaloneSearchBoxState): state is StandaloneSearchBoxState {
+    return Object.hasOwn(this.searchBoxState, 'redirectTo')
+  }
+
   public componentWillUpdate() {
     if (
-      !Object.hasOwn(this.searchBoxState, 'redirectTo') ||
+      !this.isStandaloneSearchboxState(this.searchBoxState) ||
       !Object.hasOwn(this.searchBox, 'afterRedirection')
     ) {
       return;